fix: The thumbnail needs to be displayed centered. #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
缩略图居中显示 Bug: https://pms.uniontech.com/bug-view-280001.html Log: 缩略图居中显示 v20 BUG 分支合一到v25主线 Task: https://pms.uniontech.com/task-view-383475.html
修复查看750 X 7882尺寸图片问题 Bug: https://pms.uniontech.com/bug-view-310713.html Log: 修复查看750 X 7882尺寸图片问题 v20 BUG 分支合一到v25主线 Task: https://pms.uniontech.com/task-view-383475.html
适配103x编译 task: https://pms.uniontech.com/task-view-365161.html Log: 适配103x编译 v20 BUG 分支合一到v25主线 Task: https://pms.uniontech.com/task-view-383475.html
修复右键打印不识别改后缀的图片问题 Bug: https://pms.uniontech.com/bug-view-315823.html Log: 修复右键打印不识别改后缀的图片问题 v20 BUG 分支合一到v25主线 Task: https://pms.uniontech.com/task-view-383475.html
-- The Next button should clicked double. -- The last animation not stop and logic return. Log: fix issue Bug: https://pms.uniontech.com/bug-view-328371.html v20 BUG 分支合一到v25主线 Task: https://pms.uniontech.com/task-view-383475.html
lichaofan2008
force-pushed
the
master
branch
from
7ec12fe to
52e37f1
Compare
deepin pr auto review我来对这段代码进行审查，从语法逻辑、代码质量、性能和安全几个方面分析：
if (!reader.canRead()) {
reader.setAutoDetectImageFormat(true);
reader.setDecideFormatFromContent(true);
reader.setFileName(imagePtr->filePath);
}优点：
建议：
#if DTK_VERSION > DTK_VERSION_CHECK(5, 4, 10, 0)
// 异步打印相关代码
#else
// 同步打印代码
#endif优点：
建议：
void LibImageAnimationPrivate::forceStopCurrentAnimation()
{
if (m_continuousanimationTimer) {
m_continuousanimationTimer->stop();
m_continuousanimationTimer->setInterval(0);
m_factor = 0.0f;
m_isAnimationIng = false;
}
if (m_staticTimer) {
m_staticTimer->stop();
m_staticTimer->setInterval(0);
}
}优点：
建议：
if (!reader.canRead()) {
reader.setAutoDetectImageFormat(true);
reader.setDecideFormatFromContent(true);
reader.setFileName(path);
}优点：
建议：
backgroundRect.setTopLeft(QPoint(backgroundRect.topLeft() + QPoint(0, NORMAL_ITEM_PAINT_OFFSET + 3)));
backgroundRect.setBottomRight(QPoint(backgroundRect.bottomRight() + QPoint(0, NORMAL_ITEM_PAINT_OFFSET + 3)));优点：
建议：
总体建议：
这些修改整体上是合理的，主要提高了代码的健壮性和兼容性，但还可以进一步优化代码结构和可维护性。 |
lzwind
approved these changes
Dec 23, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lichaofan2008, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
缩略图居中显示
Bug: https://pms.uniontech.com/bug-view-280001.html
Log: 缩略图居中显示
v20 BUG 分支合一到v25主线
Task: https://pms.uniontech.com/task-view-383475.html